[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

[Barry Revzin via Phabricator via cfe-commits]

BRevzin added inline comments.


================
Comment at: clang/test/AST/conditionally-trivial-smfs.cpp:39
+
+template struct DefaultConstructorCheck<2>;
+// CHECK:             "kind": "ClassTemplateSpecializationDecl",
----------------
It's possible that I just don't understand what these tests actually mean but... where is the test for `DefaultConstructorCheck<2>` having a deleted default constructor, or `DefaultConstructorCheck<3>` having a non-defaulted one?

It'd also be worthwhile to have at least one test with constaints that subsume each other instead of being mutually exclusive. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128619/new/

https://reviews.llvm.org/D128619