[PATCH] D128411: [syntax] Introduce a TokenManager interface.

Fri Jul 15 02:54:45 PDT 2022

hokein added a comment.

In D128411#3654452 <https://reviews.llvm.org/D128411#3654452>, @DavidSpickett wrote:

> FYI, after this change I get:
>
>   /home/david.spickett/llvm-project/clang/include/clang/Tooling/Syntax/TokenBufferTokenManager.h:20:7: warning: 'clang::syntax::TokenBufferTokenManager' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
>   class TokenBufferTokenManager : public TokenManager {
>         ^

Sorry, it is fixed in 30c2406e270cc5dab8da813ce5c54e4bb8c40e49 <https://reviews.llvm.org/rG30c2406e270cc5dab8da813ce5c54e4bb8c40e49>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128411/new/

https://reviews.llvm.org/D128411