[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 14 22:47:09 PDT 2022


MaskRay added a comment.

In D129832#3654040 <https://reviews.llvm.org/D129832#3654040>, @vitalybuka wrote:

> problem with included files that  we don't know which non-inlined version of the function will endup in the binary
> so using this option, user may unintentionally disable instrumentation on all included headers, even when included from a different place

This argument applies to vague linkage functions which are deduplicated.
There are many internal linkage function use cases which can benefit this, e.g. `static inline`.
But thanks for the comment. Let me improve the summary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129832/new/

https://reviews.llvm.org/D129832



More information about the cfe-commits mailing list