[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

[Scott Linder via Phabricator via cfe-commits]

scott.linder added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1207
+  auto EmitResourceUsageRemark = [&](StringRef RemarkName,
+                                     StringRef RemarkLabel, auto &&Argument) {
+    // Add an indent for every line besides the line with the kernel name. This
----------------
arsenm wrote:
> Why &&?
Looking at the `ore::NV` constructors I would vote that this just be by value, i.e. `auto Argument`. Everything that can be an `Argument` is a small "prefer passing by value" type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123878/new/

https://reviews.llvm.org/D123878