[PATCH] D128462: [HLSL] add -I option for dxc mode.

Xiang Li via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 14 14:48:33 PDT 2022


python3kgae marked an inline comment as done.
python3kgae added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:6318
+  HelpText<"CL.EXE COMPATIBILITY OPTIONS">;
+
 def cl_compile_Group : OptionGroup<"<clang-cl compile-only options>">,
----------------
beanz wrote:
> Do we need this group or can it just be `cl_Group`?
Yes. Without the group, it fails.
Also the text is keeping as cl_Group to avoid change help for cl mode.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128462/new/

https://reviews.llvm.org/D128462



More information about the cfe-commits mailing list