[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

[Vaibhav Yenamandra via Phabricator via cfe-commits]

vaibhav.y added a comment.

@aaron.ballman

The culprit turned out to be the difference in release flags on the build server vs my environment. I had unfortunately run the configuration command once in `Debug` mode, and hadn't re-configured. Not a bright moment :)

The `ASSERT_DEATH` tests that I had written weren't gated by `NDEBUG, GTEST_HAS_DEATH_TEST` (other unit tests use some combination two). This was causing them to pass on my machine but fail pre-merge (which is `RelWithDebInfo`)

I will gate the tests similar to what  https://github.com/llvm/llvm-project/blob/main/clang/unittests/Serialization/InMemoryModuleCacheTest.cpp#L48-L52  does, but force a skip instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109701/new/

https://reviews.llvm.org/D109701