[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

[Nick Desaulniers via Phabricator via cfe-commits]

nickdesaulniers added a comment.

Thanks for the review!



================
Comment at: clang/test/CodeGen/attr-function-return.c:9
 // RUN:  --check-prefixes=CHECK,CHECK-EXTERN
+// RUN: %clang_cc1 -std=gnu2x -triple x86_64-linux-gnu %s -emit-llvm -o - \
+// RUN:  -mfunction-return=thunk-extern -fprofile-arcs \
----------------
MaskRay wrote:
> I feel that having 3 RUN lines is excessive. Since we already have a test that asan/tsan/gcov respect getModuleFlag, it is not necessary for a new one to duplicate all the combinations.
All three have caused problems for us; I'd prefer to retain each.


================
Comment at: llvm/lib/IR/Function.cpp:357
   }
+  if (M->getModuleFlag("fn_return_thunk_extern"))
+    B.addAttribute(Attribute::FnRetThunkExtern);
----------------
MaskRay wrote:
> How about "function_return_thunk_extern"? fn doesn't abbreviate much. Having the `function_return` substring makes it easy for grepping.
Done, but note that this was done to match the Function Attribute.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129709/new/

https://reviews.llvm.org/D129709