[PATCH] D129048: Rewording the "static_assert" to static assertion

[Mitch Phillips via Phabricator via cfe-commits]

hctim added a comment.

Looks like unfortunately this breaks all lots of libcxx tests - which were picked up by our sanitizer buildbots:

https://lab.llvm.org/buildbot/#/builders/85/builds/9157

Should be reproducible with just `cmake -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" && make check-cxx`.

An example:

  ******************** TEST 'llvm-libc++-shared.cfg.in :: std/utilities/format/format.formatter/format.parse.ctx/ch
  eck_arg_id.verify.cpp' FAILED ********************                                                               
  Script:                                                                                                          
  --                                                                                                               
  : 'COMPILED WITH';  /llvm-build/opt/./bin/clang++ /llvm
  /libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/check_arg_id.verify.cpp  --target=x86_64-unkn
  own-linux-gnu -nostdinc++ -I /llvm-build/opt/include/c++/v1 -I /llvm-build/opt/include/x86_64-unknown-linux-gnu/c++/v1 -I /llvm/libcxx/test
  /support -std=c++2b -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno
  -pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-
  tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typ
  edef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -fcorouti
  nes-ts -Werror=thread-safety -Wuser-defined-warnings  -fsyntax-only -Wno-error -Xclang -verify -Xclang -verify-ig
  nore-unexpected=note -ferror-limit=0                                                                             
  --                                                                                                               
  Exit Code: 1                                                                                                     
                                                                                                                   
  Command Output (stdout):                                                                                         
  --                                                                                                               
  $ ":" "COMPILED WITH"                                                                                            
  $ "/llvm-build/opt/./bin/clang++" "/llvm/libcxx/test/st
  d/utilities/format/format.formatter/format.parse.ctx/check_arg_id.verify.cpp" "--target=x86_64-unknown-linux-gnu"
   "-nostdinc++" "-I" "/llvm-build/opt/include/c++/v1" "-I" "/llvm-build/opt/include/x86_64-unknown-linux-gnu/c++/v1" "-I" "/llvm/libcxx/test
  /support" "-std=c++2b" "-Werror" "-Wall" "-Wextra" "-Wshadow" "-Wundef" "-Wno-unused-command-line-argument" "-Wno
  -attributes" "-Wno-pessimizing-move" "-Wno-c++11-extensions" "-Wno-noexcept-type" "-Wno-atomic-alignment" "-Wno-u
  ser-defined-literals" "-Wno-tautological-compare" "-Wsign-compare" "-Wunused-variable" "-Wunused-parameter" "-Wun
  reachable-code" "-Wno-unused-local-typedef" "-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER" "-D_LIBCPP_ENABLE_EXPERIMENTA
  L" "-D_LIBCPP_DISABLE_AVAILABILITY" "-fcoroutines-ts" "-Werror=thread-safety" "-Wuser-defined-warnings" "-fsyntax
  -only" "-Wno-error" "-Xclang" "-verify" "-Xclang" "-verify-ignore-unexpected=note" "-ferror-limit=0"             
  # command stderr:                                                                                                
  error: 'error' diagnostics expected but not seen:                                                                
    File llvm/libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/chec
  k_arg_id.verify.cpp Line 29: static assertion expression is not an integral constant expression                  
  2 errors generated.                                                                                              
                                                                                                                   
  error: command failed with exit status: 1                                                                        
                                                                                                                   
  --                                                                                                               


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129048/new/

https://reviews.llvm.org/D129048