[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

[Qiu Chaofan via Phabricator via cfe-commits]

qiucf added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:232
+    path::remove_filename(P);
+    addSystemInclude(DriverArgs, CC1Args, P);
   }
----------------
shchenz wrote:
> Can we use `path::parent_path(P)` directly in `addSystemInclude()`? `remove_filename()` sounds like `ppc_wrappers` is a file.
It just wraps `parent_path`, and `parent_path` only accepts (and returns) `StringRef`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129461/new/

https://reviews.llvm.org/D129461