[PATCH] D128462: [HLSL] add -I option for dxc mode.

[Chris Bieneman via Phabricator via cfe-commits]

beanz added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:6824
+class DXCJoinedOrSeparateConflict<string name> : Option<["--", "/", "-"], name,
+  KIND_JOINED_OR_SEPARATE>, Group<dxc_Group>, Flags<[DXCOption, NoXarchOption]>;
 
----------------
python3kgae wrote:
> pow2clk wrote:
> > I'm not sure why this has the suffix "Conflict" In addition, you can't currently specify the "I" option with "--" in DXC.
> The conflict happened with clang-cl which use same prefix ("/", "-") as dxc.
> 
> def _SLASH_I : CLJoinedOrSeparate<"I">,
>   HelpText<"Add directory to include search path">, MetaVarName<"<dir>">,
>   Alias<I>;
Our option’s behavior is the same as _SLASH_I, so why can’t we reuse it instead of re-implementing it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128462/new/

https://reviews.llvm.org/D128462