[PATCH] D127270: [clang-format] Add space in placement new expression

omar ahmed via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 13 13:27:40 PDT 2022


omarahmed added a comment.

I don't have push credentials so If everything is okay with the patch, can you push it for me. My email is omarpiratee2010 at gmail.com



================
Comment at: clang/include/clang/Format/Format.h:3555
           AfterFunctionDefinitionName(false), AfterIfMacros(false),
-          AfterOverloadedOperator(false), AfterRequiresInClause(false),
-          AfterRequiresInExpression(false), BeforeNonEmptyParentheses(false) {}
+          AfterOverloadedOperator(false), AfterPlacementOperator(APO_Leave),
+          AfterRequiresInClause(false), AfterRequiresInExpression(false),
----------------
HazardyKnusperkeks wrote:
> We change the behavior here, I'm still not convinced we should do that. Although I'm a big supporter of the `Leave` option.
I am neutral to both cases, so I leave the choice to you as I am not experienced with clang-format users. Let me know which choice you think would be better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127270/new/

https://reviews.llvm.org/D127270



More information about the cfe-commits mailing list