[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 13 11:01:45 PDT 2022


MaskRay added a comment.

Linux tests organization isn't great. --sysroot tests both include and library search paths, so ideally we use one RUN line to test both.

The name of linux-header-search.cpp focus on just include search path. For FreeBSD/OpenBSD, if you want to start in a clean state, consider adding the RUN line to a generic test (if --sysroot is considered a core functionality) or a test with name implying "cross compilation" (that's why I created linux-cross.cpp).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129654/new/

https://reviews.llvm.org/D129654



More information about the cfe-commits mailing list