[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

[Artem Belevich via Phabricator via cfe-commits]

tra added a comment.

> Overloading the meaning of `-march` might not work here. Typically `-march` is just checked via `Args.getLastArg()`, so repeated uses just override the last one. I'm not exactly sure what the expected use is however, maybe @tra can help there. Although we could consider ones contained inside of `-Xopenmp-target=` to be different. That being said, if we wanted to support this I think the easiest way to do it would be to add handling for `-march` in the source here <https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/Driver.cpp#L4361>.

`-march` is just not flexible enough. E.g. AMDGPU has GPUs that have the same -march, but are considered to be different offloading targets.

At some point we should start consolidating the ways we can specify an offload target and try to avoid adding new ones until then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128090/new/

https://reviews.llvm.org/D128090