[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 13 10:36:04 PDT 2022


cor3ntin added a comment.

In D122768#3648545 <https://reviews.llvm.org/D122768#3648545>, @erichkeane wrote:

> Just about all of the '%' variables in LLVM are unstable names, so you need to use wildcards.  Additionally, it seems like you're checking EVERY line of the llvm function, which is likely a mistake, it ends up being incredibly unstable as a result.  I'd suggest just checking the individual lines (and the bare minimum on them!) that you need to prove that the 'right thing' is being emitted.

Thanks. I tried to simplify as much as possible. I *think* i did not remove anything of importance


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122768/new/

https://reviews.llvm.org/D122768



More information about the cfe-commits mailing list