[PATCH] D129642: [Sema] Tweak diagnostic logic so suppress-in-hedaer logic works in tools too.
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 13 07:28:36 PDT 2022
sammccall updated this revision to Diff 444253.
sammccall edited the summary of this revision.
sammccall added a comment.
Herald added a subscriber: ilya-biryukov.
add bug link to description
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129642/new/
https://reviews.llvm.org/D129642
Files:
clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
clang/lib/Sema/SemaDecl.cpp
Index: clang/lib/Sema/SemaDecl.cpp
===================================================================
--- clang/lib/Sema/SemaDecl.cpp
+++ clang/lib/Sema/SemaDecl.cpp
@@ -1773,7 +1773,7 @@
// FIXME: This needs to be refactored; some other isInMainFile users want
// these semantics.
static bool isMainFileLoc(const Sema &S, SourceLocation Loc) {
- if (S.TUKind != TU_Complete)
+ if (S.TUKind != TU_Complete || S.getLangOpts().IsHeaderFile)
return false;
return S.SourceMgr.isInMainFile(Loc);
}
Index: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
===================================================================
--- clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
+++ clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
@@ -54,6 +54,9 @@
return Field(&Diag::Fixes, UnorderedElementsAre(FixMatcher1, FixMatcher2));
}
+::testing::Matcher<const Diag &> withID(unsigned ID) {
+ return Field(&Diag::ID, ID);
+}
::testing::Matcher<const Diag &>
withNote(::testing::Matcher<Note> NoteMatcher) {
return Field(&Diag::Notes, ElementsAre(NoteMatcher));
@@ -1869,6 +1872,20 @@
"'int' to 'int *' for 1st argument; take the address of "
"the argument with &")))));
}
+
+TEST(DiagnosticsTest, UnusedInHeader) {
+ // Clang diagnoses unused static inline functions outside headers.
+ auto TU = TestTU::withCode("static inline void foo(void) {}");
+ TU.ExtraArgs.push_back("-Wunused-function");
+ TU.Filename = "test.c";
+ EXPECT_THAT(*TU.build().getDiagnostics(),
+ ElementsAre(withID(diag::warn_unused_function)));
+ // Sema should recognize a *.h file open in clangd as a header.
+ // https://github.com/clangd/vscode-clangd/issues/360
+ TU.Filename = "test.h";
+ EXPECT_THAT(*TU.build().getDiagnostics(), IsEmpty());
+}
+
} // namespace
} // namespace clangd
} // namespace clang
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129642.444253.patch
Type: text/x-patch
Size: 1889 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220713/e0e99a31/attachment-0001.bin>
More information about the cfe-commits
mailing list