[PATCH] D129048: Rewording the "static_assert" to static assertion
Muhammad Usman Shahid via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 13 07:10:43 PDT 2022
Codesbyusman marked 3 inline comments as done.
Codesbyusman added a comment.
In D129048#3647918 <https://reviews.llvm.org/D129048#3647918>, @aaron.ballman wrote:
> I think this is getting pretty close! I did have some style guideline changes, and at least one test addition I'd like to see though. Also, it looks like precommit CI caught a test that still needs to be updated:
>
> FAIL: Clang :: SemaCXX/cxx98-compat.cpp (16448 of 68726)
>
> ******************** TEST 'Clang :: SemaCXX/cxx98-compat.cpp' FAILED ********************
>
> Script:
>
> --
>
> : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/15.0.0/include -nostdsysteminc -fsyntax-only -std=c++11 -Wc++98-compat -verify /var/lib/buildkite-agent/builds/llvm-project/clang/test/SemaCXX/cxx98-compat.cpp
>
> : 'RUN: at line 2'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/15.0.0/include -nostdsysteminc -fsyntax-only -std=c++14 -Wc++98-compat -verify /var/lib/buildkite-agent/builds/llvm-project/clang/test/SemaCXX/cxx98-compat.cpp -DCXX14COMPAT
>
> : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/15.0.0/include -nostdsysteminc -fsyntax-only -std=c++17 -Wc++98-compat -verify /var/lib/buildkite-agent/builds/llvm-project/clang/test/SemaCXX/cxx98-compat.cpp -DCXX14COMPAT -DCXX17COMPAT
>
> --
>
> Exit Code: 1
>
>
>
> Command Output (stderr):
>
> --
>
> error: 'warning' diagnostics expected but not seen:
>
> File /var/lib/buildkite-agent/builds/llvm-project/clang/test/SemaCXX/cxx98-compat.cpp Line 155: static_assert declarations are incompatible with C++98
>
> error: 'warning' diagnostics seen but not expected:
>
> File /var/lib/buildkite-agent/builds/llvm-project/clang/test/SemaCXX/cxx98-compat.cpp Line 155: 'static_assert' declarations are incompatible with C++98
>
> 2 errors generated.
>
>
>
> --
>
>
>
> ********************
I just make some changes in the cxx98-compact.cpp and test was passed I was missing to update the expected-error comment for this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129048/new/
https://reviews.llvm.org/D129048
More information about the cfe-commits
mailing list