[PATCH] D129579: [clangd] Remove `allCommitCharacters`

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

sorry for being late to the party, but reading the spec <https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#:~:text=accept%20it%20first%20and%20then%20type%20that%20character> it sounds like vscode behaviour is actually the correct one (despite not being the optimal UX, at least to our understanding).

so at least for the intermediate state (and possibly ever, if LSP folks don't change the wording or add a capability) we might consider still advertising operators as commit characters (e.g. `.`, `-`, `,` ...) but i think there's an even bigger problem in vscode at the moment around combined effect of this and snippets, maybe we should disable commit characters on items with snippets and have the rest use the "safe" set of defaults. WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129579/new/

https://reviews.llvm.org/D129579