[PATCH] D129443: [clang-format] Add option for aligning requires clause body
Björn Schäpers via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 12 14:32:49 PDT 2022
HazardyKnusperkeks added a comment.
In D129443#3645795 <https://reviews.llvm.org/D129443#3645795>, @Vigilans wrote:
> In my knowledge of clang-format, `Requires Clause` and `Requires Expression` are treated differently.
> <snip>
+1 for the enum, even if we only have 2 options yet.
And yes, the option is wrongly named. You want to indent/align requires expressions, not clauses.
The tests seem mostly to suffice. You could add a test where the outer scope is indented, e.g. a class with a member function, and a test where the expression is used within an if.
Please also run `clang/docs/tools/dump_format_style.py` to update the `ClangFormatStyleOptions.rst`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129443/new/
https://reviews.llvm.org/D129443
More information about the cfe-commits
mailing list