[PATCH] D129579: [clangd] Remove `allCommitCharacters`

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 12 11:39:01 PDT 2022


hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:537
        llvm::json::Object{
-           {"allCommitCharacters",
-            {" ", "\t", "(", ")", "[", "]", "{",  "}", "<",
----------------
it would be better to have a comment explaining why we don't set `allCommitCharacters`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129579/new/

https://reviews.llvm.org/D129579



More information about the cfe-commits mailing list