[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

[ChenZheng via Phabricator via cfe-commits]

shchenz added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:226
+  // Add the PowerPC intrinsic headers (<resource>/include/ppc_wrappers)
+  if (!DriverArgs.hasArg(clang::driver::options::OPT_nostdinc) &&
+      !DriverArgs.hasArg(options::OPT_nobuiltininc)) {
----------------
`clang::driver::options::OPT_nostdinc` is not same with `options::OPT_nostdinc` in line 219?


================
Comment at: clang/test/CodeGen/PowerPC/ppc-emmintrin.c:631
 // CHECK: %[[ADDR:[0-9a-zA-Z_.]+]] = load double*, double** %{{[0-9a-zA-Z_.]+}}, align 8
-// CHECK: %[[VAL:[0-9a-zA-Z_.]+]] = load double, double* %[[ADDR]], align 8
+// CHECK: %[[VAL:[0-9a-zA-Z_.]+]] = load double, double* %[[ADDR]]
 // CHECK: call <2 x double> @vec_splats(double)(double noundef %[[VAL]])
----------------
Maybe worth investigating here why loading a double on AIX64 is not aligned to 8. This should be separated from this patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129461/new/

https://reviews.llvm.org/D129461