[PATCH] D128462: [HLSL] add -I option for dxc mode.

[Chris Bieneman via Phabricator via cfe-commits]

beanz added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:6851
   Group<dxc_Group>, Flags<[DXCOption, NoXarchOption]>, Alias<D>;
+def dxc_I : DXCJoinedOrSeparateConflict<"I">,
+  HelpText<"Add directory to include search path">,
----------------
beanz wrote:
> This option has the same behavior between DXC and clang, is there a reason we need to define a new option value instead of reusing the existing one?
As a note, the `I_Group` only has the `-I` flag, so we probably can just make `I_Group` valid for DXC.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128462/new/

https://reviews.llvm.org/D128462