[PATCH] D128845: [HLSL]Add -O and -Od option for dxc mode.

[Greg Roth via Phabricator via cfe-commits]

pow2clk added a comment.

Looks good apart from my uncertainty as to what -fcgl should or shouldn't imply



================
Comment at: clang/test/Driver/dxc_O.hlsl:9
+// CHECK: "-O0"
+// CHECK-SAME: "-dxc-opt-disable"
+
----------------
It looks to me that these are added when -Od is specified, not -fcgl (aka pristine-llvm I guess ;))

Is the comment wrong or should these be added as part of pristine-llvm too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128845/new/

https://reviews.llvm.org/D128845