[PATCH] D129068: [AST] Accept identical TypeConstraint referring to other template parameters.

[Chuanqi Xu via Phabricator via cfe-commits]

ChuanqiXu marked 2 inline comments as done.
ChuanqiXu added inline comments.


================
Comment at: clang/lib/AST/ASTContext.cpp:6254
         return false;
       if (TXTC->hasExplicitTemplateArgs() != TYTC->hasExplicitTemplateArgs())
         return false;
----------------
ilya-biryukov wrote:
> Do we even want to compare the template argument sizes here?
> Would comparing only `getImmediatelyDeclaredConstraint` produce the same results?
> 
> If that's a performance optimization, we are probably better off moving it inside `isSameConstraintExpr`.
> 
I've moved them into `isSameTypeConstraint`. Now the code looks better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129068/new/

https://reviews.llvm.org/D129068