[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

Mon Jul 11 10:51:37 PDT 2022

iains added a comment.

In D126189#3642992 <https://reviews.llvm.org/D126189#3642992>, @JDevlieghere wrote:

> In D126189#3642820 <https://reviews.llvm.org/D126189#3642820>, @iains wrote:
>
>> JFTR, I did not get any notification from green dragon (which is odd, AFAIR it's sent email before) or I would have looked right away  - kicked off a build will take a look as soon as that's done.
>
> Yes, the bot was already red because of a different issue.
>
> FWIW I tried reverting ac507102d258b6fc0cb57eb60c9dfabd57ff562f <https://reviews.llvm.org/rGac507102d258b6fc0cb57eb60c9dfabd57ff562f> and 4328b960176f4394416093e640ad4265bde65ad7 <https://reviews.llvm.org/rG4328b960176f4394416093e640ad4265bde65ad7> locally and I'm still getting a linker error about missing symbols:

those refs come up as 'bad object' for me .. can you identify the upstream changes?

>   Undefined symbols for architecture arm64:
>     "vtable for std::__1::format_error", referenced from:
>         std::__1::format_error::format_error(char const*) in main.o
>         std::__1::format_error::format_error(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in main.o

That seems also unrelated to the modules code, but I could always be surprised :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126189/new/

https://reviews.llvm.org/D126189