[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

Iain Sandoe via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 11 09:58:10 PDT 2022


iains added a comment.

In D126189#3642779 <https://reviews.llvm.org/D126189#3642779>, @JDevlieghere wrote:

> In D126189#3642777 <https://reviews.llvm.org/D126189#3642777>, @iains wrote:
>
>> In D126189#3642762 <https://reviews.llvm.org/D126189#3642762>, @JDevlieghere wrote:
>>
>>> This breaks TestDataFormatterLibcxxSpan.py on GreenDragon:

....

>>> https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/45207/
>>
>> ack, (I develop on macOS so usually catch these things)...
>> do you need me to revert the commit - or can we try to find out what's broken and fix it?
>
> If you think you'll be able to get to the bottom of this quickly then I don't think we need to revert, but the bot has been red for a while (which means that other issues can get buried) so I'd like to get it green ASAP.

JFTR, I did not get any notification from green dragon (which is odd, AFAIR it's sent email before) or I would have looked right away  - kicked off a build will take a look as soon as that's done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126189/new/

https://reviews.llvm.org/D126189



More information about the cfe-commits mailing list