[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

Mon Jul 11 09:41:06 PDT 2022

JDevlieghere added a comment.

In D126189#3642777 <https://reviews.llvm.org/D126189#3642777>, @iains wrote:

> In D126189#3642762 <https://reviews.llvm.org/D126189#3642762>, @JDevlieghere wrote:
>
>> This breaks TestDataFormatterLibcxxSpan.py on GreenDragon:
>>
>>   Undefined symbols for architecture x86_64:
>>     "__ZGIW10std_config", referenced from:
>>         __GLOBAL__sub_I_main.cpp in main.o
>>     "__ZGIW4span", referenced from:
>>         __GLOBAL__sub_I_main.cpp in main.o
>>     "__ZGIW5array", referenced from:
>>         __GLOBAL__sub_I_main.cpp in main.o
>>     "__ZGIW5stdio", referenced from:
>>         __GLOBAL__sub_I_main.cpp in main.o
>>     "__ZGIW6string", referenced from:
>>         __GLOBAL__sub_I_main.cpp in main.o
>>     "__ZGIW6vector", referenced from:
>>         __GLOBAL__sub_I_main.cpp in main.o
>>
>> https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/45207/
>
> ack, (I develop on macOS so usually catch these things)...
> do you need me to revert the commit - or can we try to find out what's broken and fix it?

If you think you'll be able to get to the bottom of this quickly then I don't think we need to revert, but the bot has been red for a while (which means that other issues can get buried) so I'd like to get it green ASAP.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126189/new/

https://reviews.llvm.org/D126189