[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

Mon Jul 11 09:08:19 PDT 2022

aaron.ballman added a comment.

In D109701#3642561 <https://reviews.llvm.org/D109701#3642561>, @vaibhav.y wrote:

> Discard most likely culprit in test code causing unexpected crash.
>
> @aaron.ballman I was unable to reproduce the issue on my end using the buildbot instructions and ASAN, UBSAN.
>
> Is it possible for you to trigger a pre-merge check on the LLVM cluster?

Unfortunately, there isn't.

> I have suspicions that it was the `SarifResult &&` type in the test so I changed it to a `const SarifResult &`.
>
> I've tried running it on a RHEL 7, Darwin on my end.

If you think you've got it fixed, I think the best we can do is to re-commit and watch the bots to see how they react. I'll commit again for you and watch them.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109701/new/

https://reviews.llvm.org/D109701