[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

Joseph Huber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 8 10:44:12 PDT 2022


jhuber6 added a comment.

In D129301#3639318 <https://reviews.llvm.org/D129301#3639318>, @yaxunl wrote:

> I think before the new binary format supports Windows and -fno-gpu-rdc and HIP runtime support the new binary format, we cannot deprecate clang-offload-bundler. I expect that would take some time.

Supporting `-fno-gpu-rdc` should be easy, this will just require a few tweaks to the driver phases and passing it to the host backend directly. Supporting Windows would be a little tougher, we would need to make sure we can embed / extract the device code with Windows. After that we would need to synthesize the start / stop pointers differently. There is a way to do this on Windows similar to how Unix linkers, there's some examples in ASAN or HWSAN I believe. It's definitely doable but would take some effort, so it definitely won't work in time for the 15 release. I personally don't have much interest in Mac or Windows, but if I want to make this format universal I may need to actually sit down and implement it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129301/new/

https://reviews.llvm.org/D129301



More information about the cfe-commits mailing list