[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added a comment.

In D129301#3637664 <https://reviews.llvm.org/D129301#3637664>, @jhuber6 wrote:

> In D129301#3637642 <https://reviews.llvm.org/D129301#3637642>, @jdoerfert wrote:
>
>> Isn't the offload bundler on it's "way out" (=replaced and then deleted soon)?
>
> HIP still uses it to create their `fatbinary` format for CUDA-like support for multi-architecture binaries as well as their object file format. Once D128914 <https://reviews.llvm.org/D128914> is landed we can at least compile HIP without it, but we would still need to use it to create the bundled image until AMD decides to support my stuff in their runtime. Beyond that I'm not aware of what the users will be now that OpenMP uses the new interface by default. I'm not in a big hurry to delete this if people still have a use for it, but I'd prefer things to use the new interface if possible. Are there any other situations where we still need the `clang-offload-bundler`? If there's anything the new interface is lacking I could add it in.

I think before the new binary format supports Windows and -fno-gpu-rdc and HIP runtime support the new binary format, we cannot deprecate clang-offload-bundler. I expect that would take some time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129301/new/

https://reviews.llvm.org/D129301