[PATCH] D129353: [clang-tidy] Improve check cert-dcl58-cpp.

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/cert/DontModifyStdNamespaceCheck.cpp:29
+      continue;
+    ArrayRef<TemplateArgument> List1 = Arg.getPackAsArray();
+    if (matchesFirstInRange(InnerMatcher, List1.begin(), List1.end(), Finder,
----------------
Might as well give this a better name so it's less similar to `List`.


================
Comment at: clang-tools-extra/clang-tidy/cert/DontModifyStdNamespaceCheck.cpp:92
+  auto BadFunctionTemplateSpec =
+      functionDecl(unless(cxxMethodDecl()), isExplicitTemplateSpecialization(),
+                   HasNoProgramDefinedTemplateArgument, HasStdParent);
----------------
This one is missing the system header check, but I wonder if that can be handled once in the call to `addMatcher()` instead of needing to be sprinkled here?


================
Comment at: clang-tools-extra/clang-tidy/cert/DontModifyStdNamespaceCheck.cpp:138
+}
\ No newline at end of file

----------------
You should add the newline back.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129353/new/

https://reviews.llvm.org/D129353