[PATCH] D129100: [clangd] Support external throttler for preamble builds

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 8 00:25:07 PDT 2022


kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:499
         // Build the preamble and let the waiters know about it.
         build(std::move(*CurrentReq));
       }
----------------
regarding the flakiness, what about resetting the `Throttle` here to trigger the release? it's right after the build and would make sure release happens before the context is destroyed (+ we're not holding any locks)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129100/new/

https://reviews.llvm.org/D129100



More information about the cfe-commits mailing list