[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.
Martin Storsjö via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 7 15:12:54 PDT 2022
mstorsjo updated this revision to Diff 443075.
mstorsjo added a comment.
Add `/*Diags=*/nullptr` for clarity, as suggested.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129277/new/
https://reviews.llvm.org/D129277
Files:
clang/lib/Serialization/ASTReader.cpp
Index: clang/lib/Serialization/ASTReader.cpp
===================================================================
--- clang/lib/Serialization/ASTReader.cpp
+++ clang/lib/Serialization/ASTReader.cpp
@@ -5171,8 +5171,9 @@
bool ReadPreprocessorOptions(const PreprocessorOptions &PPOpts,
bool Complain,
std::string &SuggestedPredefines) override {
- return checkPreprocessorOptions(ExistingPPOpts, PPOpts, nullptr, FileMgr,
- SuggestedPredefines, ExistingLangOpts);
+ return checkPreprocessorOptions(PPOpts, ExistingPPOpts, /*Diags=*/nullptr,
+ FileMgr, SuggestedPredefines,
+ ExistingLangOpts);
}
};
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129277.443075.patch
Type: text/x-patch
Size: 800 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220707/99913b08/attachment.bin>
More information about the cfe-commits
mailing list