[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 7 13:26:42 PDT 2022


shafik added inline comments.


================
Comment at: clang/lib/Serialization/ASTReader.cpp:5174
                                  std::string &SuggestedPredefines) override {
-      return checkPreprocessorOptions(ExistingPPOpts, PPOpts, nullptr, FileMgr,
+      return checkPreprocessorOptions(PPOpts, ExistingPPOpts, nullptr, FileMgr,
                                       SuggestedPredefines, ExistingLangOpts);
----------------
Nitpick `/*Diags=*/nullptr`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129277/new/

https://reviews.llvm.org/D129277



More information about the cfe-commits mailing list