[PATCH] D128612: RISC-V big-endian support implementation

Alex Bradbury via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 7 08:36:26 PDT 2022


asb added a comment.

Thanks for this patch Guy. As just discussed in the RISC-V sync-up call, it would be helpful from a review perspective to write down at least a simple plain-text description of the changes to the psABI doc needed to reflect the BE ABI implemented by GCC (and soon LLVM), perhaps in an issue.

I think this patch is lacking some test coverage around things like fixup handling (e.g. the logic to swap fixups).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128612/new/

https://reviews.llvm.org/D128612



More information about the cfe-commits mailing list