[PATCH] D129250: [clang-repl][NFC] Split weak symbol test to a new test

Jun Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 7 07:15:00 PDT 2022


junaire updated this revision to Diff 442902.
junaire added a comment.

extern printf so we can use, another copy paster mistake...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129250/new/

https://reviews.llvm.org/D129250

Files:
  clang/test/Interpreter/execute-weak.cpp
  clang/test/Interpreter/execute.cpp


Index: clang/test/Interpreter/execute.cpp
===================================================================
--- clang/test/Interpreter/execute.cpp
+++ clang/test/Interpreter/execute.cpp
@@ -3,7 +3,6 @@
 // RUN:            'auto r1 = printf("i = %d\n", i);' | FileCheck --check-prefix=CHECK-DRIVER %s
 // REQUIRES: host-supports-jit
 // UNSUPPORTED: system-aix
-// XFAIL: system-windows
 // CHECK-DRIVER: i = 10
 // RUN: cat %s | clang-repl | FileCheck %s
 extern "C" int printf(const char *, ...);
@@ -19,8 +18,4 @@
 inline int foo() { return 42; }
 int r3 = foo();
 
-int __attribute__((weak)) bar() { return 1; }
-auto r4 = printf("bar() = %d\n", bar());
-// CHECK-NEXT: bar() = 1
-
 %quit
Index: clang/test/Interpreter/execute-weak.cpp
===================================================================
--- clang/test/Interpreter/execute-weak.cpp
+++ clang/test/Interpreter/execute-weak.cpp
@@ -7,20 +7,8 @@
 // CHECK-DRIVER: i = 10
 // RUN: cat %s | clang-repl | FileCheck %s
 extern "C" int printf(const char *, ...);
-int i = 42;
-auto r1 = printf("i = %d\n", i);
-// CHECK: i = 42
-
-struct S { float f = 1.0; S *m = nullptr;} s;
-
-auto r2 = printf("S[f=%f, m=0x%llx]\n", s.f, reinterpret_cast<unsigned long long>(s.m));
-// CHECK-NEXT: S[f=1.000000, m=0x0]
-
-inline int foo() { return 42; }
-int r3 = foo();
-
-int __attribute__((weak)) bar() { return 1; }
+int __attribute__((weak)) bar() { return 42; }
 auto r4 = printf("bar() = %d\n", bar());
-// CHECK-NEXT: bar() = 1
+// CHECK: bar() = 42
 
 %quit


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129250.442902.patch
Type: text/x-patch
Size: 1517 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220707/5e367b4b/attachment.bin>


More information about the cfe-commits mailing list