[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files
Balázs Benics via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 7 04:42:37 PDT 2022
steakhal added a comment.
Sorry about my delayed response. I was busy.
I've left a couple comments inline. Nothing serious.
Thanks for the patch!
================
Comment at: clang/docs/ReleaseNotes.rst:593
+
+- clang-extdef-mapping now accepts .ast files as input. This is faster than to
+ recompile the files from sources when extracting method definitons. This can
----------------
I think we need to use double back ticks for preformatted/code texts.
================
Comment at: clang/docs/ReleaseNotes.rst:595
+ recompile the files from sources when extracting method definitons. This can
+ be really beneficial when creating .ast files for input to the clang-static-analyzer.
+
----------------
================
Comment at: clang/tools/clang-extdef-mapping/ClangExtDefMapGen.cpp:42
+ : Ctx(Context), SM(Context.getSourceManager()) {
+ CurrentFileName = astFilePath.str();
+ }
----------------
Why is this not initialized in the //initialized-list// like the rest of the members?
================
Comment at: clang/tools/clang-extdef-mapping/ClangExtDefMapGen.cpp:149
+ if (!CI)
+ CI = new CompilerInstance();
+
----------------
What takes the ownership of `CI`? When is it deleted?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128704/new/
https://reviews.llvm.org/D128704
More information about the cfe-commits
mailing list