[PATCH] D129223: [Clang] Fix invalid utf-8 detection

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 6 14:05:23 PDT 2022


cor3ntin added a comment.

In D129223#3633849 <https://reviews.llvm.org/D129223#3633849>, @thakis wrote:

> Reverted in e9fe20dab39edb911afacdb6ed9ec2c7499a59cf <https://reviews.llvm.org/rGe9fe20dab39edb911afacdb6ed9ec2c7499a59cf> for now.

Thanks, I was going to do that when I noticed you already did, very much appreciated.
The patch (well, the one before) appeared to have multiple off-by one errors that cancelled each other and were not caught due to insufficient test cases
Once I find a fix, I'll get it reviewed again. Sorry for the inconvenience


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129223/new/

https://reviews.llvm.org/D129223



More information about the cfe-commits mailing list