[PATCH] D129100: [clangd] Support external throttler for preamble builds

Andres Freund via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 6 09:35:14 PDT 2022


Hi,

On 2022-07-06 16:28:14 +0000, Sam McCall via Phabricator wrote:
> sammccall added a comment.
> 
> In D129100#3633073 <https://reviews.llvm.org/D129100#3633073>, @anarazel wrote:
> 
> > This caused llvm builds to fail for me (using clang-14, debug, debian unstable, lld as linker):
> 
> Thanks, I have a very similar setup but the build passed locally, I'll never understand linkers...

Might depend on optimization level (if references are discovered to be dead,
there's no undefined reference)?


> I think I've fixed this in e7fa272bc6a6a504c2899bb7cf66029678d97890 <https://reviews.llvm.org/rGe7fa272bc6a6a504c2899bb7cf66029678d97890>

Looks good now, thanks!

Greetings,

Andres Freund


More information about the cfe-commits mailing list