[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 6 03:30:58 PDT 2022


gribozavr2 added inline comments.


================
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:263-267
+  //// Possible return values are:
+  /// - `Satisfiable`  : There exists a satisfying assignment for `Constraints`,
+  ///                    the solution found by the solver will be returned.
   /// - `Unsatisfiable`: There is no satisfying assignment for `Constraints`.
+  /// - `TimedOut`     : The solver gives up on finding a satisfying assignment.
----------------
I'd suggest to revert these edits. Vertical alignment that is not supported by an autoformatter isn't sustainable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129180/new/

https://reviews.llvm.org/D129180



More information about the cfe-commits mailing list