[PATCH] D129158: [pseudo] Define recovery strategy as grammar extension.

[Haojian Wu via Phabricator via cfe-commits]

hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/pseudo/lib/cxx/CXX.cpp:46
+  assert(Begin > 0);
+  const Token &Left = Tokens.tokens()[Begin - 1];
+  if (const Token *Right = Left.pair())
----------------
nit: assert Left is a left bracket?


================
Comment at: clang-tools-extra/pseudo/lib/cxx/CXX.cpp:54
+  return {
+      {(ExtensionID)Extension::Brackets, recoverBrackets},
+  };
----------------
btw, it is annoying to write an explicit ExtensionID<=>Extension conversion. To avoid that, what do you think of making the Symbol&Extension as an `enum` rather than `enum class`, and we still keep the qualified name usage `Extension::Brackets`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129158/new/

https://reviews.llvm.org/D129158