[PATCH] D129152: [Clang][unittests] Silence trucation warning with MSVC
Denys Petrov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 5 11:44:26 PDT 2022
ASDenysPetrov accepted this revision.
ASDenysPetrov added a comment.
This revision is now accepted and ready to land.
@aganea Thank you for fixing this.
`TestValues` structure impies to hold a set of values which can do some kind of convertions including truncations. This is what tests are about. That's true, it may happen that some test cases don't need some values. You can carry them out to some `TestValues2` structure and use them instead. That also would work. So it's up to you. I'm OK with both solutions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129152/new/
https://reviews.llvm.org/D129152
More information about the cfe-commits
mailing list