[PATCH] D129048: Rewording the "static_assert" to static assertion

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 5 09:15:21 PDT 2022


aaron.ballman added a comment.

In D129048#3630584 <https://reviews.llvm.org/D129048#3630584>, @Codesbyusman wrote:

> Yes I am looking into the DiagnosticParseKinds.td

Excellent, thank you!

In D129048#3630589 <https://reviews.llvm.org/D129048#3630589>, @Codesbyusman wrote:

> Yes I am looking into the DiagnosticParseKinds.td. Kindly also look another error encountered in testing while updating the test. Although not having in my system but this  is giving .
> Look here <https://buildkite.com/llvm-project/premerge-checks/builds/101000#0181cebf-2f7e-435d-873c-3e4eb15e20f5/6-15575>

I noticed that one earlier -- I think it's unrelated to your changes. (I've seen that test spuriously fail before and there's nothing in the test files that uses a static assertion, so it seems highly unlikely that changes to the diagnostic message caused that issue; I expect it will go away on its own when you push up another patch in the future.) I think it's safe for you to ignore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129048/new/

https://reviews.llvm.org/D129048



More information about the cfe-commits mailing list