[PATCH] D129104: [Modules] Add ODR Check for concepts

[Erich Keane via Phabricator via cfe-commits]

erichkeane added inline comments.


================
Comment at: clang/lib/AST/ASTContext.cpp:6532
+      const Expr *XCE = ConceptX->getConstraintExpr();
+      const Expr *YCE = ConceptY->getConstraintExpr();
+      assert(XCE && YCE && "ConceptDecl wihtout constraint expression?");
----------------
This isn't necessarily valid here, you did a dyn_cast above.


================
Comment at: clang/lib/AST/ASTContext.cpp:6533
+      const Expr *YCE = ConceptY->getConstraintExpr();
+      assert(XCE && YCE && "ConceptDecl wihtout constraint expression?");
+      llvm::FoldingSetNodeID XID, YID;
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129104/new/

https://reviews.llvm.org/D129104