[PATCH] D129100: [clangd] Support external throttler for preamble builds

[Sam McCall via Phabricator via cfe-commits]

sammccall planned changes to this revision.
sammccall added a comment.

Summarizing an offline discussion:

- ThrottlerState isolates complexity inside TUScheduler by absolving Throttler of the need to worry about callback lifetimes
- but it does so at the cost of extra aggregate complexity (third object with different lifetime & own threading model)
- the main alternative seems to be to allow deregistration of callbacks on throttler (addListener/removeListener)
  - planning to give that a try.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129100/new/

https://reviews.llvm.org/D129100