[PATCH] D129068: [AST] Profiling on constraint expression instead of arguments for TypeConstraint in ASTContext::isSameTemplateParameter

[Volodymyr Sapsai via Phabricator via cfe-commits]

vsapsai added a comment.

I don't know enough to say if it is a good approach or not, I'll need to check what we can achieve by modifying `Profile` in `ArgLoc.getArgument().Profile`. Specifically, I'm interested to see if we can use the same `ASTContext` for profile. Also I have a few stylistic comments but I want to figure out high-level stuff first.

And I have some ideas about the tests. It might be covered elsewhere but I'm curious if there are any not-isSameTemplateParameter test cases? Also it can be useless but will it work with the deeper template nesting? Something like `C<Level1<Level2>>`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129068/new/

https://reviews.llvm.org/D129068