[clang] 47bdf53 - [clang-format] Break on AfterColon only if not followed by comment
via cfe-commits
cfe-commits at lists.llvm.org
Mon Jul 4 12:35:03 PDT 2022
Author: owenca
Date: 2022-07-04T12:34:19-07:00
New Revision: 47bdf53a5dbaf16e1080d1cad8f3cc67edaad960
URL: https://github.com/llvm/llvm-project/commit/47bdf53a5dbaf16e1080d1cad8f3cc67edaad960
DIFF: https://github.com/llvm/llvm-project/commit/47bdf53a5dbaf16e1080d1cad8f3cc67edaad960.diff
LOG: [clang-format] Break on AfterColon only if not followed by comment
Break after a constructor initializer colon only if it's not followed by a
comment on the same line.
Fixes #41128.
Fixes #43246.
Differential Revision: https://reviews.llvm.org/D129057
Added:
Modified:
clang/lib/Format/ContinuationIndenter.cpp
clang/lib/Format/TokenAnnotator.cpp
clang/unittests/Format/FormatTest.cpp
Removed:
################################################################################
diff --git a/clang/lib/Format/ContinuationIndenter.cpp b/clang/lib/Format/ContinuationIndenter.cpp
index 2cb985cdc4e54..e957852ba9859 100644
--- a/clang/lib/Format/ContinuationIndenter.cpp
+++ b/clang/lib/Format/ContinuationIndenter.cpp
@@ -404,6 +404,7 @@ bool ContinuationIndenter::mustBreak(const LineState &State) {
(State.Column + State.Line->Last->TotalLength - Previous.TotalLength >
getColumnLimit(State) ||
CurrentState.BreakBeforeParameter) &&
+ (!Current.isTrailingComment() || Current.NewlinesBefore > 0) &&
(Style.AllowShortFunctionsOnASingleLine != FormatStyle::SFS_All ||
Style.BreakConstructorInitializers != FormatStyle::BCIS_BeforeColon ||
Style.ColumnLimit != 0)) {
@@ -793,6 +794,7 @@ void ContinuationIndenter::addTokenOnCurrentLine(LineState &State, bool DryRun,
(Previous.is(tok::colon) && Previous.is(TT_ObjCMethodExpr)))) {
CurrentState.LastSpace = State.Column;
} else if (Previous.is(TT_CtorInitializerColon) &&
+ (!Current.isTrailingComment() || Current.NewlinesBefore > 0) &&
Style.BreakConstructorInitializers ==
FormatStyle::BCIS_AfterColon) {
CurrentState.Indent = State.Column;
@@ -1032,7 +1034,7 @@ unsigned ContinuationIndenter::addTokenOnNewLine(LineState &State,
// be considered bin packing unless the relevant AllowAll option is false or
// this is a dict/object literal.
bool PreviousIsBreakingCtorInitializerColon =
- Previous.is(TT_CtorInitializerColon) &&
+ PreviousNonComment && PreviousNonComment->is(TT_CtorInitializerColon) &&
Style.BreakConstructorInitializers == FormatStyle::BCIS_AfterColon;
if (!(Previous.isOneOf(tok::l_paren, tok::l_brace, TT_BinaryOperator) ||
PreviousIsBreakingCtorInitializerColon) ||
diff --git a/clang/lib/Format/TokenAnnotator.cpp b/clang/lib/Format/TokenAnnotator.cpp
index 029cb9097871c..98c012994f450 100644
--- a/clang/lib/Format/TokenAnnotator.cpp
+++ b/clang/lib/Format/TokenAnnotator.cpp
@@ -4734,7 +4734,7 @@ bool TokenAnnotator::canBreakBefore(const AnnotatedLine &Line,
// the first list element. Otherwise, it should be placed outside of the
// list.
return Left.is(BK_BracedInit) ||
- (Left.is(TT_CtorInitializerColon) &&
+ (Left.is(TT_CtorInitializerColon) && Right.NewlinesBefore > 0 &&
Style.BreakConstructorInitializers == FormatStyle::BCIS_AfterColon);
}
if (Left.is(tok::question) && Right.is(tok::colon))
@@ -4894,8 +4894,10 @@ bool TokenAnnotator::canBreakBefore(const AnnotatedLine &Line,
if (Right.is(tok::identifier) && Right.Next && Right.Next->is(TT_DictLiteral))
return true;
- if (Left.is(TT_CtorInitializerColon))
- return Style.BreakConstructorInitializers == FormatStyle::BCIS_AfterColon;
+ if (Left.is(TT_CtorInitializerColon)) {
+ return Style.BreakConstructorInitializers == FormatStyle::BCIS_AfterColon &&
+ (!Right.isTrailingComment() || Right.NewlinesBefore > 0);
+ }
if (Right.is(TT_CtorInitializerColon))
return Style.BreakConstructorInitializers != FormatStyle::BCIS_AfterColon;
if (Left.is(TT_CtorInitializerComma) &&
diff --git a/clang/unittests/Format/FormatTest.cpp b/clang/unittests/Format/FormatTest.cpp
index c4066253fd1a5..e506d0dbf3a5e 100644
--- a/clang/unittests/Format/FormatTest.cpp
+++ b/clang/unittests/Format/FormatTest.cpp
@@ -7034,6 +7034,10 @@ TEST_F(FormatTest, BreakConstructorInitializersAfterColon) {
"SomeClass::Constructor() :\n"
" aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaaaa(aaaaaaaaaaaa) {}",
Style);
+ verifyFormat(
+ "SomeClass::Constructor() : // NOLINT\n"
+ " aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaaaa(aaaaaaaaaaaa) {}",
+ Style);
Style.PackConstructorInitializers = FormatStyle::PCIS_BinPack;
verifyFormat(
@@ -7101,6 +7105,10 @@ TEST_F(FormatTest, BreakConstructorInitializersAfterColon) {
" aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n"
" aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}",
OnePerLine);
+ verifyFormat("Foo::Foo(int i, int j) : // NOLINT\n"
+ " i(i), // comment\n"
+ " j(j) {}",
+ OnePerLine);
verifyFormat("MyClass::MyClass(int var) :\n"
" some_var_(var), // 4 space indent\n"
" some_other_var_(var + 1) { // lined up\n"
@@ -7133,6 +7141,17 @@ TEST_F(FormatTest, BreakConstructorInitializersAfterColon) {
" // Comment forcing unwanted break.\n"
" aaaa(aaaa) {}",
Style);
+ verifyFormat("Constructor() : // NOLINT\n"
+ " aaaa(aaaa) {}",
+ Style);
+ verifyFormat("Constructor() : // A very long trailing comment that cannot fit"
+ " on a single\n"
+ " // line.\n"
+ " aaaa(aaaa) {}",
+ "Constructor() : // A very long trailing comment that cannot fit"
+ " on a single line.\n"
+ " aaaa(aaaa) {}",
+ Style);
Style.ColumnLimit = 0;
verifyFormat("SomeClass::Constructor() :\n"
More information about the cfe-commits
mailing list