[PATCH] D129045: [C++20][Modules] Update handling of implicit inlines [P1779R3]

Iain Sandoe via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 4 05:30:34 PDT 2022


iains marked an inline comment as done.
iains added a comment.

In D129045#3627901 <https://reviews.llvm.org/D129045#3627901>, @ChuanqiXu wrote:

> In D129045#3627878 <https://reviews.llvm.org/D129045#3627878>, @iains wrote:
>
>> In D129045#3627856 <https://reviews.llvm.org/D129045#3627856>, @ChuanqiXu wrote:
>>
>>> It looks like the tests lack the cast that the methods are attached to the global module fragment.
>>
>> (maybe I misunderstand what you are saying here)



> I mean the tests instead of the implementation. It looks like there is no GMF in the tests.

added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129045/new/

https://reviews.llvm.org/D129045



More information about the cfe-commits mailing list