[PATCH] D129045: [C++20][Modules] Update handling of implicit inlines [P1779R3]

[Chuanqi Xu via Phabricator via cfe-commits]

ChuanqiXu added a comment.

In D129045#3627878 <https://reviews.llvm.org/D129045#3627878>, @iains wrote:

> In D129045#3627856 <https://reviews.llvm.org/D129045#3627856>, @ChuanqiXu wrote:
>
>> It looks like the tests lack the cast that the methods are attached to the global module fragment.
>
> (maybe I misunderstand what you are saying here)
>
>   bool ImplicitInlineCXX20 = !getLangOpts().CPlusPlus20 ||
>                                  !NewFD->getOwningModule() ||
>                                  NewFD->getOwningModule()->isGlobalModule();
>
> We are in the global module if there is no owning module, or if the owning module is the GMF. 
>  We always set this to true before C++20, matching the unconditional true default argument it the setImplicitlyInline() method.

I mean the tests instead of the implementation. It looks like there is no GMF in the tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129045/new/

https://reviews.llvm.org/D129045