[PATCH] D128757: [Driver][test] Add -fuse-ld= option tests for NetBSD

Frederic Cambus via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 3 11:59:07 PDT 2022


fcambus added a comment.

In D128757#3616795 <https://reviews.llvm.org/D128757#3616795>, @MaskRay wrote:

> I am unsure it is useful to add a test for all OSxfuse_ld_value combinations, especially for an ELF OS like NetBSD which shares many characteristics with other ELF OSes. It will be overwhelming.
> The option may be better added in a netbsd specific file.

I noticed there is a `fuse-ld-windows.c` file with some tests, so would putting NetBSD ones in a new `fuse-ld-netbsd.c` file make sense?

Either way, I don't have any strong opinion on this. I can also drop the revision if those tests do not seem useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128757/new/

https://reviews.llvm.org/D128757



More information about the cfe-commits mailing list