[PATCH] D129042: Reland "[NFC] Add a missing test for for clang-repl"

Jun Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 3 03:09:43 PDT 2022


junaire created this revision.
junaire added a reviewer: v.g.vassilev.
Herald added a project: All.
junaire requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

This reverts 3668d1264e2d246f7e222338b8a5cab18ce1bdab <https://reviews.llvm.org/rG3668d1264e2d246f7e222338b8a5cab18ce1bdab>
As far as we know, `__attribute__((weak))` support has been really bad
in runtimeldyld, so we just disable it in Windows at this moment. This
should fix the angry Windows buildbot.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D129042

Files:
  clang/test/Interpreter/execute.cpp


Index: clang/test/Interpreter/execute.cpp
===================================================================
--- clang/test/Interpreter/execute.cpp
+++ clang/test/Interpreter/execute.cpp
@@ -3,6 +3,7 @@
 // RUN:            'auto r1 = printf("i = %d\n", i);' | FileCheck --check-prefix=CHECK-DRIVER %s
 // REQUIRES: host-supports-jit
 // UNSUPPORTED: system-aix
+// XFAIL: windows-msvc
 // CHECK-DRIVER: i = 10
 // RUN: cat %s | clang-repl | FileCheck %s
 extern "C" int printf(const char *, ...);
@@ -18,4 +19,8 @@
 inline int foo() { return 42; }
 int r3 = foo();
 
+int __attribute__((weak)) bar() { return 1; }
+auto r4 = printf("bar() = %d\n", bar());
+// CHECK-NEXT: bar() = 1
+
 %quit


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129042.441933.patch
Type: text/x-patch
Size: 692 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220703/44527caa/attachment.bin>


More information about the cfe-commits mailing list